Add correlation-based localization options - #30
Merged
Merged
Conversation
Collaborator
|
@iangrooms Awesome! Thanks for filling this in, it's been an empty placeholder for a while. I also have the source code for Morzfeld NICE scheme, which I can add later. |
Contributor
Author
|
@myying my pleasure! I hope it is useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two correlation-based localization functions: one based on generalized cross-validation (preprint coming soon), and a 'prior-optimal' localization scheme from Menetrier et al. (2015) (see also Morzfeld and Hodyss (2023)). They are qualitatively similar to Anderson's Sampling Error Correction (2012) but without the need for pre-computation and a lookup table. The new options can be enabled by adding a "correlation" line to the config.yml file. E.g.
The correlation-based schemes can be turned off with either "correlation: null" or "type: null". Generally these should be used in combination with distance-based localization, which they tend to make more robust to changes in the localization radius.
The PR also makes two other very minor changes:
vartossfor 'sum of squares.' This saves a very small amount of cost and could be rolled back to increase code readability.