Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix set_content_units: E & W GPS coordinates were in backwards! #159

Merged
merged 4 commits into from
Sep 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# EMLeditor v0.1.6
## 2024-09-17
* Update `set_content_units` to have correct east and west GPS coordinates for bounding boxes.
## 2024-08-29
* Update readme: add R-CMD-CHECK badge; use pak to install instead of devtools
* Update licenseName field on restricted references to read, "Unlicensed (not for public dissemination)"
Expand Down
4 changes: 2 additions & 2 deletions R/editEMLfunctions.R
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,8 @@ set_content_units <- function(eml_object, park_units,
poly <- as.data.frame(poly[[1]][1])
N <- max(poly[, 2])
S <- min(poly[, 2])
W <- max(poly[, 1])
E <- min(poly[, 1])
W <- min(poly[, 1])
E <- max(poly[, 1])
geocov <- EML::eml$geographicCoverage(
geographicDescription =
paste0("NPS Content Unit Link: ", park_units[i]),
Expand Down
5 changes: 3 additions & 2 deletions docs/news/index.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/pkgdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ articles:
a03_Template_edits: a03_Template_edits.html
a04_Editing_fixing_eml: a04_Editing_fixing_eml.html
a05_advanced_functionality: a05_advanced_functionality.html
last_built: 2024-08-29T22:56Z
last_built: 2024-09-18T02:07Z