Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

Change colour of links to pass the WCAG contrast ratio guidelines and… #29

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

wormmoon
Copy link

… make them readable

Current colour #30def6 has a low contrast ratio with the background colour #f6f6f6 and may be unreadable for some people. Does not pass test on https://contrast-ratio.com/. New colour #237480 does pass this test.

@shiffman
Copy link
Member

Thank you so much for this! ❤️❤️❤️

I'm working with some collaborators at ITP to make the materials more WCAG compliant and this is super helpful. A couple quick comments:

  1. If possible, can you include a screenshot illustrating the difference (this is helpful when reviewing pull requests!)
  2. Ultimately, this change will need to be made in The Nature of Code book source repo as this is what generates the html/css/etc files that I transfer over here when updating the book content.

@shiffman shiffman added the accessibility Issues related to WCAG compliance label Sep 22, 2018
@wormmoon
Copy link
Author

Thank you so much for this! ❤️❤️❤️

I'm working with some collaborators at ITP to make the materials more WCAG compliant and this is super helpful. A couple quick comments:

  1. If possible, can you include a screenshot illustrating the difference (this is helpful when reviewing pull requests!)
  2. Ultimately, this change will need to be made in The Nature of Code book source repo as this is what generates the html/css/etc files that I transfer over here when updating the book content.

Ahh thank /you/ for this book!

Okay I will do this today!

@shiffman
Copy link
Member

shiffman commented Nov 3, 2022

Apologies that this was never addressed! I am working on a new design that I would will be more accessible at https://github.com/nature-of-code/book-website-2nd-edition

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Issues related to WCAG compliance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants