Improve typing

nautechsystems · Feb 17, 2023 · 7e0e9d0 · 7e0e9d0
1 parent 1381785
commit 7e0e9d0
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/nautilus_trader/config/common.py b/nautilus_trader/config/common.py
@@ -513,7 +513,7 @@ def create(self):
 
 class ImportableConfig(NautilusConfig, frozen=True):
     """
-    Represents an importable (typically live data or execution) client configuration.
+    Represents an importable (typically live data client or live execution client) configuration.
     """
 
     path: str

diff --git a/nautilus_trader/config/live.py b/nautilus_trader/config/live.py
@@ -154,9 +154,9 @@ class TradingNodeConfig(NautilusKernelConfig, frozen=True):
         The live execution engine configuration.
     streaming : StreamingConfig, optional
         The configuration for streaming to feather files.
-    data_clients : dict[str, ImportableConfig], optional
+    data_clients : dict[str, ImportableConfig | LiveDataClientConfig], optional
         The data client configurations.
-    exec_clients : dict[str, ImportableConfig], optional
+    exec_clients : dict[str, ImportableConfig | LiveExecClientConfig], optional
         The execution client configurations.
     strategies : list[ImportableStrategyConfig]
         The strategy configurations for the node.
@@ -178,7 +178,6 @@ class TradingNodeConfig(NautilusKernelConfig, frozen=True):
         The timeout for all engine clients to disconnect.
     timeout_post_stop : PositiveFloat (seconds)
         The timeout after stopping the node to await residual events before final shutdown.
-
     """
 
     environment: Environment = Environment.LIVE

diff --git a/nautilus_trader/live/node_builder.py b/nautilus_trader/live/node_builder.py
@@ -143,7 +143,7 @@ def build_data_clients(self, config: dict[str, ImportableConfig]):
 
         Parameters
         ----------
-        config : dict[str, object]
+        config : dict[str, ImportableConfig | LiveDataClientConfig]
             The data clients configuration.
 
         """
@@ -191,7 +191,7 @@ def build_exec_clients(self, config: dict[str, ImportableConfig]):
 
         Parameters
         ----------
-        config : dict[str, object]
+        config : dict[str, ImportableConfig | LiveExecClientConfig]
             The execution clients configuration.
 
         """

diff --git a/nautilus_trader/system/kernel.py b/nautilus_trader/system/kernel.py
@@ -229,7 +229,7 @@ def __init__(  # noqa (too complex)
 
         # Setup loop (if live)
         if environment == Environment.LIVE:
-            self._loop: asyncio.AbstractEventLoop = loop or asyncio.get_event_loop()
+            self._loop: Optional[asyncio.AbstractEventLoop] = loop or asyncio.get_event_loop()
             if loop is not None:
                 self._executor = concurrent.futures.ThreadPoolExecutor()
                 self._loop.set_default_executor(self.executor)