Fixed issue with dynamic groups not being called in 2.3.0. #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itdependsnetworks
requested review from
jeffkala and
nkallergis
as code owners
jeffkala
reviewed
Aug 26, 2024
| @@ -478,6 +478,8 @@ def _generate_config_plan_from_manual(self): | |||
|
|
|||
| def run(self, **data): | |||
| """Run config plan generation process.""" | |||
| self.logger.debug("Updating Dynamic Group Cache.") | |||
| update_dynamic_groups_cache() | |||
There was a problem hiding this comment.
maybe we should do a job input. Should "we" force this, or allow a job user to say I want to force the refresh.
There was a problem hiding this comment.
perhaps its a non-issue now but the refreshing of the cache was always the biggest time consumer.
jeffkala
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.