Add GraphQL output to the "Generate Intended Config" view #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsnider2195
requested review from
itdependsnetworks,
jeffkala and
nkallergis
as code owners
smk4664
reviewed
Dec 4, 2024
smk4664
approved these changes
Dec 4, 2024
| @@ -23,7 +40,7 @@ | |||
| <a href="{% url 'plugins:nautobot_golden_config:goldenconfig_list' %}">Config Overview</a> page. | |||
| </p> | |||
| <p> | |||
| This will render the configuration for the selected device using Jinja templates from the golden config <code>jinja_repository</code> | |||
| This will render the configuration for the selected device using Jinja templates from the Golden Config <code>jinja_repository</code> | |||
There was a problem hiding this comment.
Suggested change
| This will render the configuration for the selected device using Jinja templates from the Golden Config <code>jinja_repository</code> | |
| This will render the configuration for the selected device using Jinja templates from the Golden Config Setting <code>jinja_repository</code> |
There was a problem hiding this comment.
Though, the setting is just called Golden Config, so I could go either way on this one.
There was a problem hiding this comment.
@cmsirbu is going to try to get some input on the wording here
| @@ -8,6 +8,23 @@ | |||
| .button-container { | |||
| margin-bottom: 24px; | |||
| } | |||
| pre:has(code) { | |||
There was a problem hiding this comment.
Why is this needed?
There was a problem hiding this comment.
Bootstrap has a default of 11.5px here so the code block inside of the pre block doesn't fill the box completely.
default
with this fix
This was referenced Dec 5, 2024
jeffkala
approved these changes
Dec 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots