Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework and expand the Items section #39

Merged
merged 10 commits into from
Jan 14, 2024
Merged

Rework and expand the Items section #39

merged 10 commits into from
Jan 14, 2024

Conversation

IchHabeHunger54
Copy link
Member

@IchHabeHunger54 IchHabeHunger54 commented Dec 18, 2023 •
edited
Loading

Reworks and expands the Items section. Specifically, it:

  • Rewrites the items page.
  • Adds information on food, and further documentation on Item.Properties.
  • Explains the difference between items and itemstacks.
  • Adds a new article about tools and armor, including explanations for the TierSortingRegistry and the ToolAction system.
  • Adds an article about NBT.
  • Adds an article about mob effects and potions.

Preview URL: https://pr-39.neoforged-docs-previews.pages.dev

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 18, 2023 21:17 Active
@neoforged-pages-deployments
Copy link

neoforged-pages-deployments bot commented Dec 18, 2023 •
edited
Loading

Deploying with Cloudflare Pages

Name Result
Last commit: 24852512066cc58337ab31a3ad2ef20712e2437a
Status: ✅ Deploy successful!
Preview URL: https://9a300027.neoforged-docs-previews.pages.dev
PR Preview URL: https://pr-39.neoforged-docs-previews.pages.dev

ChampionAsh5357
ChampionAsh5357 requested changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@ChampionAsh5357 ChampionAsh5357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good so far! Needs a bit more explanation with the many annoying complexities of stacks and materials. Also added a few nitpicky comments, but if you can't think of anything better, feel free to ignore.

docs/items/index.md Outdated Show resolved Hide resolved
docs/items/index.md Show resolved Hide resolved
docs/items/index.md Outdated Show resolved Hide resolved
docs/items/index.md Show resolved Hide resolved
docs/items/index.md Outdated Show resolved Hide resolved
docs/items/tools.md Outdated Show resolved Hide resolved
docs/items/tools.md Outdated Show resolved Hide resolved
docs/items/tools.md Outdated Show resolved Hide resolved
docs/items/tools.md Outdated Show resolved Hide resolved
docs/items/tools.md Show resolved Hide resolved
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) January 3, 2024 01:00 Active
ChampionAsh5357
ChampionAsh5357 requested changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@ChampionAsh5357 ChampionAsh5357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments and nitpicks.

docs/items/index.md Outdated Show resolved Hide resolved
docs/items/index.md Outdated Show resolved Hide resolved
docs/items/index.md Outdated Show resolved Hide resolved
docs/items/mobeffects.md Show resolved Hide resolved
docs/items/mobeffects.md Show resolved Hide resolved
docs/items/mobeffects.md Show resolved Hide resolved
docs/items/mobeffects.md Show resolved Hide resolved
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) January 3, 2024 19:11 Active
@IchHabeHunger54 IchHabeHunger54 marked this pull request as ready for review January 3, 2024 20:17
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) January 3, 2024 20:18 Active
@IchHabeHunger54
Copy link
Member Author

This is it, everything I consider to be in the scope of the PR is added. Reviews please.

ChampionAsh5357
ChampionAsh5357 requested changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@ChampionAsh5357 ChampionAsh5357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two nitpick comments, but looks fine. Will ping for any additional review, but otherwise can be merged in Monday afterward.

docs/datastorage/nbt.md Outdated Show resolved Hide resolved
docs/datastorage/nbt.md Outdated Show resolved Hide resolved
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) January 3, 2024 23:36 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) January 4, 2024 12:23 Active
@IchHabeHunger54 IchHabeHunger54 merged commit 148f084 into neoforged:main Jan 14, 2024
1 check passed
@ChampionAsh5357 ChampionAsh5357 mentioned this pull request Jan 19, 2024
Open
83 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChampionAsh5357 ChampionAsh5357 ChampionAsh5357 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IchHabeHunger54 @ChampionAsh5357