Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify extension point system #80

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

Technici4n
Copy link
Member

Removes the self-type and the record restriction. Also allows directly passing an object instead of wrapping it in a supplier.

To register a config screen factory, usage should go from

modContainer.registerExtensionPoint(
        ConfigScreenHandler.ConfigScreenFactory.class,
        () -> new ConfigScreenHandler.ConfigScreenFactory((mc, parentScreen) -> AutoConfig.getConfigScreen(MIConfig.class, parentScreen).get()));

to

modContainer.registerExtensionPoint(
        IConfigScreenFactory.class,
        (mc, parentScreen) -> AutoConfig.getConfigScreen(MIConfig.class, parentScreen).get());

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Mar 25, 2024

  • Publish PR to GitHub Packages

Last commit published: 476e9e660f6437a97031f79323ccf589b11a8455.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #80' // https://github.com/neoforged/FancyModLoader/pull/80
        url 'https://prmaven.neoforged.net/FancyModLoader/pr80'
        content {
            includeModule('net.neoforged.fancymodloader', 'loader')
            includeModule('net.neoforged.fancymodloader', 'earlydisplay')
            includeModule('net.neoforged.fancymodloader', 'spi')
        }
    }
}

@Technici4n Technici4n merged commit 82313aa into neoforged:main Mar 25, 2024
2 checks passed
@Technici4n Technici4n deleted the simplify-ext-point branch March 25, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants