Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two current issues with the
jst-cli-bundle
publication that result in wacky metadata. First, theshadow.component(...)
method is used to add the shadow jar to the publication -- this approach does not, in fact, use a component, but just manually adds the artifact, and adds dependencies to the pom. This probably helped hide the actual issue a bit -- the actual issue being thatshadowRuntimeElements.extendsFrom shadow
within the shadow plugin itself, as the shadow plugin uses theshadow
configuration to mean "things you're not bundling, and hence need to publish a dependency on". However, the jst-cli buildscript reuses this name for "things that should be bundled" and so the jst-cli-bundle published a dependency on everything it bundled. This PR fixes this, and uses a component for publishing so we get gradle module metadata.