Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vlan #27

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Vlan #27

wants to merge 3 commits into from

Conversation

ffainelli
Copy link
Contributor

I am seeing the following error that I don't quite understand, must be something wrong with my handling of the list indexes...:

`
DEBUG: TelnetControl: Executing: ip link del gphy.2
DEBUG: TelnetControl: Command returned 0
DEBUG: LocalControl: Executing: ip link del eth1.2
DEBUG: LocalControl: Command returned 0
DEBUG: TelnetControl: Executing: ip link del gphy.3
DEBUG: TelnetControl: Command returned 0
EE

ERROR: test_port_ping_vlan_all (tests.port.vlan.TestPingVlan)

Traceback (most recent call last):
File "/home/fainelli/dev/github/dsatest/dsatest/tests/port/vlan.py", line 39, in test_port_ping_vlan_all
host_vlan = link.host_if.vlan_interfaces[vid]
IndexError: list index out of range

======================================================================
ERROR: test_port_ping_vlan_all (tests.port.vlan.TestPingVlan)

Traceback (most recent call last):
File "/home/fainelli/dev/github/dsatest/dsatest/tests/port/vlan.py", line 30, in tearDown
link.target_if.del_vlan(vid)
File "/home/fainelli/dev/github/dsatest/dsatest/bench/interface.py", line 57, in del_vlan
self.vlan_interfaces.pop(vid)
IndexError: pop index out of range


Ran 1 test in 4.639s

FAILED (errors=2)
zsh: exit 2 sudo ./dsatest.sh -B ~/.dsatest/7278.cfg -t port_ping_vlan_all -vvv

`

This is clearly useful to other parts of the code, migrate ping.py while
at it.
VLAN interfaces are indexed by their VLAN ID and function like normal
network interfaces (as expected)
Iterate over a bunch of VLAN IDs to make sure that the switch accepts
forwarding packets which are tagged.
@ffainelli
Copy link
Contributor Author

Fixed the above problem by using a dictionary, thanks @d-k-c!

@d-k-c d-k-c force-pushed the master branch 2 times, most recently from ac6b5fe to fed2b04 Compare March 15, 2018 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant