This repository has been archived by the owner on Jun 2, 2024. It is now read-only.
Make calling the user_info endpoint optional #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes strategy initialization
|
@ondrejpialek |
|
@ondrejpialek |
It should be tied to the session. Will get rid of most nonce validation issues stemming from the users using the back-button or multiple tabs. Version bump.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that the user_info endpoint is not called when the Omiauth setting
skip_infois set.This is useful for example when integrating with Azure AD B2C, which does not expose this endpoint. It may also be useful in cases where we only care about the ID or access token - this will save one HTTP call.
I also run the file through prettifier to make the syntax consistent, I hope that is ok.
Also note the version bump to
0.9.5, but feel free to update this as necessary.