Fix upslog legacy code
#2762
Open
Fix upslog legacy code
#2762
+112
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_t to header, rename the latter with "_t" Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
…ethods and avoid shared global vars for single UPS NOTE: The logbuffer and logformat remain shared, the former is cleaned before use in run_flist() anyway. Might be passed around, too, but why keep re-allocating and freeing memory (or tossing more stack bytes with pointer and size to static variable of that method)?.. Signed-off-by: Jim Klimov <[email protected]>
…x `%UPSHOST%%t` before the format string Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added
enhancement
feature
refactor/fightwarn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue work started by @cschuber - and complete the conversion of
upslogto primarily use the tuple-oriented structures internally, without shared variables of the older single-UPS logging approach - pass aroundstruct monhost_ups_t *instead as explicit args.Also update #2756 improvements with a new
-NCLI option to prepend%UPSHOST%%tinto formatting strings, to ease logging of multiple devices into same target (stdout or file).