Fix OpenAI functions + streaming #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanKadri
commented
Jan 5, 2024
| content += chunk.choices[0].delta.get("content", "") | ||
| if hasattr(chunk.choices[0].delta, "role"): | ||
| role = chunk.choices[0].delta.role | ||
| if len(chunk.choices) > 0: |
There was a problem hiding this comment.
I'm not sure why this happens but some chunks were returning with no choices. I saw that same behavior in Node I think. It might be an implementation detail or it might signal that the stream is starting?
RyanKadri
commented
Jan 5, 2024
| role = chunk.choices[0].delta.role | ||
| if len(chunk.choices) > 0: | ||
| content += chunk.choices[0].delta.get("content", "") or "" | ||
| delta_role = getattr(chunk.choices[0].delta, "role", None) |
There was a problem hiding this comment.
It seems like the content or role can both be None even after a previous chunk had a role. Only track the role when there's a value here
bonczj
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using OpenAI functions with streaming, it looks like some of our assumptions about the chunk data break.