-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(firebase-adapter): update firebase-admin
peer-dep to 12.0.0+
#11293
chore(firebase-adapter): update firebase-admin
peer-dep to 12.0.0+
#11293
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@tomas-mikula is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
@ndom91 @balazsorban44 any chance you had time to take a look? |
@thomas-desmond can change this peer dependency limit to something like Also you don't have to manually bump the version of the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11293 +/- ##
=======================================
Coverage 39.47% 39.47%
=======================================
Files 184 184
Lines 29262 29262
Branches 1263 1269 +6
=======================================
Hits 11552 11552
Misses 17710 17710 ☔ View full report in Codecov by Sentry. |
Hey folks, any updates on this? I had hard time playing with the example repo and firebase adapter (tldr; it doesn't work) and fixing this would be really helpful |
Hi, is there any update on this? Thanks! |
@ndom91 is it now considered ready? Or do we wait for someone specific? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
firebase-admin
dependency to version 12.0.0
firebase-admin
dependency to version 12.0.0firebase-admin
peer-dep to 12.0.0+
☕️ Reasoning
There is a dependency resolution issue when trying to use
@auth/firebase-adapter
alongsidefirebase-admin
.Specifically
"@auth/firebase-adapter": "^2.4.1"
doesn't seem to support firebase-admin version 12 such as"firebase-admin": "^12.2.0"
Issue:
firebase-adapter
peerDependencies and devDependancies offirebase-admin
were update to v12.🧢 Checklist
🎫 Affected issues
None
📌 Resources