Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(firebase-adapter): update firebase-admin peer-dep to 12.0.0+ #11293

Conversation

tomas-mikula
Copy link
Contributor

@tomas-mikula tomas-mikula commented Jun 30, 2024

☕️ Reasoning

There is a dependency resolution issue when trying to use @auth/firebase-adapter alongside firebase-admin.
Specifically "@auth/firebase-adapter": "^2.4.1" doesn't seem to support firebase-admin version 12 such as "firebase-admin": "^12.2.0"

Issue:
Screenshot 2024-06-30 at 22 18 45

firebase-adapter peerDependencies and devDependancies of firebase-admin were update to v12.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

None

📌 Resources

Copy link

vercel bot commented Jun 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs 🛑 Canceled (Inspect) Aug 28, 2024 7:36pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 7:36pm

Copy link

vercel bot commented Jun 30, 2024

@tomas-mikula is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters firebase @auth/firebase-adapter labels Jun 30, 2024
Copy link

socket-security bot commented Jun 30, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@simplewebauthn/[email protected] None 0 42 kB iamkale
npm/@simplewebauthn/[email protected] network +6 1.53 MB iamkale
npm/@solidjs/[email protected] None 0 20.4 kB ryansolid
npm/@supabase/[email protected] network +8 2.26 MB kiwicopple
npm/@sveltejs/[email protected] environment, filesystem, shell 0 7.03 kB svelte-admin
npm/@sveltejs/[email protected] environment 0 7.09 kB svelte-admin
npm/@sveltejs/[email protected] environment, eval 0 730 kB svelte-admin
npm/@sveltejs/[email protected] None 0 27.7 kB svelte-admin
npm/@sveltejs/[email protected] None +1 150 kB svelte-admin
npm/@types/[email protected] None +2 250 kB types
npm/@types/[email protected] None +10 110 kB types
npm/@types/[email protected] None 0 13.8 kB types
npm/@types/[email protected] None 0 13.9 kB types
npm/@types/[email protected] None 0 3.56 MB types
npm/@types/[email protected] None 0 3.99 MB types
npm/@types/[email protected] None 0 2.03 MB types
npm/@types/[email protected] None 0 88.9 kB types
npm/@types/[email protected] None 0 14.2 kB types
npm/@types/[email protected] None +18 144 kB types
npm/@types/[email protected] None 0 9.7 kB types
npm/@types/[email protected] None 0 33.3 kB types
npm/@types/[email protected] None +2 362 kB types
npm/@types/[email protected] None +2 380 kB types
npm/@types/[email protected] None +1 439 kB types
npm/@types/[email protected] None 0 6.99 kB types
npm/@types/[email protected] None +3 38.6 kB types
npm/@types/[email protected] None 0 6.67 kB types
npm/@typescript-eslint/[email protected] None +10 5.22 MB jameshenry
npm/@typescript-eslint/[email protected] None +7 4.99 MB jameshenry
npm/@typescript-eslint/[email protected] None +4 1.37 MB jameshenry
npm/@typescript-eslint/[email protected] None +4 1.39 MB jameshenry
npm/@upstash/[email protected] environment, network 0 275 kB hezarfen
npm/@vercel/[email protected] None 0 190 kB vercel-release-bot
npm/@vitest/[email protected] None +7 736 kB oreanno
npm/@vitest/[email protected] None +1 974 kB oreanno

🚮 Removed packages: npm/@auth/[email protected]), npm/@radix-ui/[email protected]), npm/@radix-ui/[email protected]), npm/@radix-ui/[email protected]), npm/@types/[email protected]), npm/@types/[email protected]), npm/@types/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected])

View full report↗︎

Copy link

socket-security bot commented Jun 30, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Install scripts npm/@swc/[email protected]
  • Install script: postinstall
  • Source: node postinstall.js
🚫
Install scripts npm/@sveltejs/[email protected]
  • Install script: postinstall
  • Source: node postinstall.js
🚫

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@tomas-mikula tomas-mikula changed the title bump(adapter-firebase): update firebase-admin dependency to version 12.0.0 bump(firebase-adapter): update firebase-admin dependency to version 12.0.0 Jul 1, 2024
@tomas-mikula
Copy link
Contributor Author

@ndom91 @balazsorban44 any chance you had time to take a look?

@ndom91
Copy link
Member

ndom91 commented Jul 21, 2024

@thomas-desmond can change this peer dependency limit to something like >= 12, in order to allow any 12.x version?

Also you don't have to manually bump the version of the @auth/firebase-adapter package, that'll happen automatically in the CI release job 🙏

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.47%. Comparing base (5122d2e) to head (bec43d9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11293   +/-   ##
=======================================
  Coverage   39.47%   39.47%           
=======================================
  Files         184      184           
  Lines       29262    29262           
  Branches     1263     1269    +6     
=======================================
  Hits        11552    11552           
  Misses      17710    17710           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacekplocharczyk
Copy link

Hey folks, any updates on this? I had hard time playing with the example repo and firebase adapter (tldr; it doesn't work) and fixing this would be really helpful
Thanks!

@Jason59000
Copy link

Hi, is there any update on this? Thanks!

@tomas-mikula
Copy link
Contributor Author

@ndom91 is it now considered ready? Or do we wait for someone specific?

Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ndom91 ndom91 changed the title bump(firebase-adapter): update firebase-admin dependency to version 12.0.0 chore(firebase-adapter): update firebase-admin dependency to version 12.0.0 Aug 28, 2024
@ndom91 ndom91 changed the title chore(firebase-adapter): update firebase-admin dependency to version 12.0.0 chore(firebase-adapter): update firebase-admin peer-dep to 12.0.0+ Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters Changes related to the core code concerning database adapters firebase @auth/firebase-adapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants