Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid excessive Env URL and basePath redundant Warning #11636

Merged
merged 20 commits into from
Aug 26, 2024

Conversation

k-taro56
Copy link
Contributor

@k-taro56 k-taro56 commented Aug 20, 2024

☕️ Reasoning

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Fixes: #11522

📌 Resources

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 4:02pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 4:02pm

Copy link

vercel bot commented Aug 20, 2024

@k-taro56 is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added core Refers to `@auth/core` next-auth labels Aug 20, 2024
@k-taro56 k-taro56 changed the title Fix/10429 fix: Avoid excessive Env URL and basePath redundant Warning Aug 20, 2024
Copy link
Member

@ThangHuuVu ThangHuuVu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this LGTM, I tested it locally! I think it's good to go

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.47%. Comparing base (86772bc) to head (e80507d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11636      +/-   ##
==========================================
+ Coverage   39.45%   39.47%   +0.02%     
==========================================
  Files         184      184              
  Lines       29249    29263      +14     
  Branches     1261     1269       +8     
==========================================
+ Hits        11540    11552      +12     
- Misses      17709    17711       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThangHuuVu ThangHuuVu merged commit 69c0b58 into nextauthjs:main Aug 26, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` next-auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AUTH_URL gives [auth][warn][env-url-basepath-redundant]
2 participants