-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): cleanup built-in pages docs page #11661
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@halvaradop is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
ndom91
reviewed
Aug 28, 2024
ndom91
reviewed
Aug 28, 2024
halvaradop
force-pushed
the
docs/built-in-pages
branch
from
August 29, 2024 16:21
f04ea13
to
2311727
Compare
I have made the changes based on your suggestions. 🧙♂️ |
ndom91
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
ndom91
changed the title
chore(docs): add examples for built-in pages
chore(docs): cleanup built-in pages docs page
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
This pull request adds code examples to the
Built-in Pages
section for the frameworks supported by Auth.js, including Next.js, Qwik, and SvelteKit. The examples demonstrate how automatic page generation works when the user provides providers in their configuration file.Additionally, to avoid code repetition across frameworks, the provider configurations are now written in a separate file.
On the other hand, the code for the
SignInButton
component in the Next.js example has been removed. The focus is on demonstrating how to set up built-in pages. If you believe theSignInButton
component is relevant, please let me know, and I will make the necessary changes.🧢 Checklist
🎫 Affected issues
📌 Resources