Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): cleanup built-in pages docs page #11661

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

halvaradop
Copy link
Contributor

☕️ Reasoning

This pull request adds code examples to the Built-in Pages section for the frameworks supported by Auth.js, including Next.js, Qwik, and SvelteKit. The examples demonstrate how automatic page generation works when the user provides providers in their configuration file.

Additionally, to avoid code repetition across frameworks, the provider configurations are now written in a separate file.

On the other hand, the code for the SignInButton component in the Next.js example has been removed. The focus is on demonstrating how to set up built-in pages. If you believe the SignInButton component is relevant, please let me know, and I will make the necessary changes.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 4:03pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 4:03pm

Copy link

vercel bot commented Aug 23, 2024

@halvaradop is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@halvaradop halvaradop force-pushed the docs/built-in-pages branch from f04ea13 to 2311727 Compare August 29, 2024 16:21
@halvaradop
Copy link
Contributor Author

I have made the changes based on your suggestions. 🧙‍♂️

Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@ndom91 ndom91 changed the title chore(docs): add examples for built-in pages chore(docs): cleanup built-in pages docs page Sep 11, 2024
@ndom91 ndom91 merged commit 285cb5c into nextauthjs:main Sep 11, 2024
11 of 13 checks passed
@halvaradop halvaradop deleted the docs/built-in-pages branch September 18, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants