-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding mysql-adapter #11856
base: main
Are you sure you want to change the base?
adding mysql-adapter #11856
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@MAHB98 is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits to suggest but I am planning on adopting this myself to avoid pulling a heavy-weight ORM into my own project.
"url": "git+https://github.com/MAHB98/mysql-adapter.git" | ||
}, | ||
"keywords": [ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove blank line
"author": "MAHB98", | ||
"license": "ISC", | ||
"bugs": { | ||
"url": "https://github.com/MAHB98/mysql-adapter/issues" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URL doesn't exist- remove or replace with this repo's issues
"tslib": "^2.6.3" | ||
}, | ||
"devDependencies": { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove extra line
"homepage": "https://github.com/MAHB98/mysql-adapter#readme", | ||
"dependencies": { | ||
"@auth/core": "^0.34.1", | ||
"tsc": "^2.0.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tsc is deprecated
Personally I would love to have this, although it'd also be nice if it were updated to support the new passkeys/webauthn functionality. |
☕️ Reasoning
🧢 Checklist
🎫 Affected issues
📌 Resources