Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): update type import in typescript.md #8948

Closed
wants to merge 1 commit into from

Conversation

FrankTrog
Copy link

While attempting to utilize this page in a local version of Auth.js the recommended code failed to augment the module properly. It seems the reference to @auth/core module doesn't properly augment it.

NOTE:

  • It's a good idea to open an issue first to discuss potential changes.
  • Please make sure that you are NOT opening a PR to fix a potential security vulnerability. Instead, please follow the Security guidelines to disclose the issue to us confidentially.

☕️ Reasoning

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Please scout and link issues that might be solved by this PR.

Fixes: INSERT_ISSUE_LINK_HERE

📌 Resources

While attempting to utilize this page in a local version of Auth.js the recommended code failed to augment the module properly. It seems the reference to @auth/core module doesn't properly augment it.
@FrankTrog FrankTrog requested a review from ubbe-xyz as a code owner October 25, 2023 15:53
@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 3:57pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 3:57pm

@vercel
Copy link

vercel bot commented Oct 25, 2023

@FrankTrog is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@nolykhemin
Copy link

this works, thanks

@mr-josh
Copy link

mr-josh commented Dec 21, 2023

Is this related to #9377? I notice the change reverts the deceleration to "next-auth" but I think @Huijiro found the correct module (@auth/core/types).

@ndom91
Copy link
Member

ndom91 commented Dec 24, 2023

Closing this PR, the correct import is from @auth/core/types👍

@ndom91 ndom91 changed the title Correct typescript.md fix(docs): update type import in typescript.md Dec 24, 2023
@ndom91 ndom91 closed this Dec 24, 2023
@mr-josh
Copy link

mr-josh commented Dec 25, 2023

@ndom91 is there a PR to correct the docs from @auth/core to @auth/core/types? I can spin up a fork real quick and patch if not.

Also Merry Christmas to all that celebrate!

@Huijiro
Copy link
Contributor

Huijiro commented Dec 25, 2023

@ndom91 is there a PR to correct the docs from @auth/core to @auth/core/types? I can spin up a fork real quick and patch if not.

Also Merry Christmas to all that celebrate!

I was about to try to do it as soon as i arrive home to say i did something in open source for once.

@Huijiro
Copy link
Contributor

Huijiro commented Dec 25, 2023

@mr-josh Done in #9462.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants