Repository navigation
Conversation
The dialog for an image too large to edit named a File source "[object File]". It now uses the file name, or "This image" for a bare Blob. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
A Blob without a type decoded fine, as browsers read the format from the bytes, but export decided everything on blob.type: a JPEG was saved as a PNG, lost its EXIF and was never handed back untouched. The export now reads JPEG, PNG and WebP from the first bytes where the type is empty. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Adds a local-file demo to the playground (?demo=local-file), a README section on editing a local file, and an e2e test that edits a picked File and checks the Blob that comes back. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
β Deploy Preview for nextcloud-image-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
==========================================
+ Coverage 45.07% 45.33% +0.26%
==========================================
Files 57 57
Lines 5085 5113 +28
Branches 497 511 +14
==========================================
+ Hits 2292 2318 +26
- Misses 2790 2791 +1
- Partials 3 4 +1 β View full report in Codecov by Harness. π New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileorBlobwork fully, with no serverDetails
Fixed
A Blob without a
typelost its format on export. Such a Blob (new Blob([bytes]), or aFilewith an extension the browser does not know) loaded fine, because browsers read the format from the bytes. The export only looked atblob.type, so a JPEG:The export now reads JPEG, PNG and WebP from the first bytes when
typeis empty. No new prop or API.The downscale dialog named a File "[object File]". It now uses the file name, or "This image" for a bare Blob.
Added
?demo=local-file(playground/LocalFileDemo.vue). Pick a file, edit it, preview or download the result. It also shows how to handlecancelanderror.Checked, no change needed
loadImage) is revoked infinally, on success and on failure. Tests for this already exist.errorand shows the retry. It never hangs.Demo:
https://deploy-preview-85--nextcloud-image-editor.netlify.app/?demo=local-file
Talk branch to test:
https://github.com/nextcloud/spreed/tree/feat/noid/edit-staged-images
π€ AI (if applicable)