-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset attendees participation on eventDrop #5532
Conversation
8afbae7
to
f839b1f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5532 +/- ##
============================================
+ Coverage 22.28% 24.83% +2.55%
Complexity 388 388
============================================
Files 240 240
Lines 11793 10573 -1220
Branches 2301 1710 -591
============================================
- Hits 2628 2626 -2
+ Misses 9165 7947 -1218
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
f839b1f
to
d8d8681
Compare
I'd argue that it doesn't fully but only for events modified through our client and when they are dragged and dropped. Changes through other channels will still have the bug. 👍 for the workaround though |
Let's not close the server issue, if we can't merge sabre-io/dav#1443 in sabre we can always patch it in 3rdparty. |
I agree, it addresses the server bug but resolves it only for the web client. Could we use this workaround until a proper fix is implemented? I looked into the sabre-dav code and a proper fix is propably more complicated |
d8d8681
to
eec206f
Compare
@miaulalala Signed my commit, tests should now hopefully pass :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works.
Unfortunately tests are failing |
eec206f
to
2382c89
Compare
Signed-off-by: Jonas Heinrich <[email protected]>
2382c89
to
a568764
Compare
thank you for noticing! fixed the tests :) should still work as intended |
/backport to stable4.5 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Following change resets participation state of all attendees (except organizer) on eventDrop to NEEDS-ACTION. Considering that eventDrop would be always a significant change. This will trigger resending of an invitation.
This is a workaround for sabre-dav doesn't respecting RFC 6638 3.2.8: sabre-io/dav#1282
Addresses: nextcloud/server#13862