upload the zsync file

[Fuseteam]

i might still need to look into deleting the old zsync file just like it's deleting the old appimage file but otherwise this is ready

[nextcloud-desktop-bot]

AppImage file:

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[Fuseteam]

i don't quite see why it failed

[Thatoo]

It fails because devs didn't yet review it which is the first step.

@FlexW and @mgallien could you review this PR please that would allow to upload the zsync file missing for the AppImage to be able to auto-update .

[mgallien]

@Fuseteam very sorry for the extra delay on our side to get a proper review

thanks for your work

[Fuseteam]

no worries, i look forward to the review~

p.s. i see the DCO is now failing, anything i need to do?

[Thatoo]

no worries, i look forward to the review~

p.s. i see the DCO is now failing, anything i need to do?

Yes, you'll have to merge the master branch into your Fuseteam:fix-appimage-update branch. However, don't do it right now as you'll have to do it everytime something change in master till you merge so wait for the review and when the review is ok, you merge master into your branch and then DCO will start again and will be, hopefully, OK.

[mgallien]

no worries, i look forward to the review~

p.s. i see the DCO is now failing, anything i need to do?

The best is to follow the instructions here

[Fuseteam]

@mgallien is the review ok?

[Fuseteam]

@mgallien the DCO is fine now
tho one of the workflow yaml files seems broken, afaik my pr didn't touch it

[Fuseteam]

bah the rebase broke the DCO xd

[Thatoo]

@mgallien could you review please and tell @Fuseteam if something is wrong in his code?

[Fuseteam]

@mgallien are there are blockers left for this PR?

[mgallien]

@mgallien are there are blockers left for this PR?

not sure how to test the upgrade path of an AppImage
@Fuseteam do you have pointers to documentation about that ?
despite having to work with AppImage, I am still lacking some good docs reference

[mgallien]

@mgallien are there are blockers left for this PR?

DCO is still unhappy
see error message

Commit sha: [22bbfef](https://github.com/nextcloud/desktop/pull/4529/commits/22bbfef50d500e4d0a7e885b098144bb41bbeaf2), Author: Rahammetoela Toekiman, Committer: Matthieu Gallien; Expected "Rahammetoela Toekiman [[email protected]](mailto:[email protected])", but got "Fuseteam [[email protected]](mailto:[email protected])".

[codecov]

Codecov Report

Merging #4529 (a3bab86) into master (10b623e) will decrease coverage by 2.33%.
The diff coverage is n/a.

❗ Current head a3bab86 differs from pull request most recent head 8b3539e. Consider uploading reports for the commit 8b3539e to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4529      +/-   ##
==========================================
- Coverage   60.16%   57.83%   -2.33%     
==========================================
  Files         145      141       -4     
  Lines       18771    18149     -622     
==========================================
- Hits        11293    10496     -797     
- Misses       7478     7653     +175     

see 70 files with indirect coverage changes

[Fuseteam]

@mgallien are there are blockers left for this PR?

not sure how to test the upgrade path of an AppImage @Fuseteam do you have pointers to documentation about that ? despite having to work with AppImage, I am still lacking some good docs reference

i do not, but iirc https://github.com/AppImageCommunity/AppImageUpdate uses the zsync file to detect if there's an update and download it

[Fuseteam]

@mgallien DCO seems happy now, not sure about the rest

[Fuseteam]

Oh wait now i see the full error

[Fuseteam]

@mgallien now it should be fine

[Fuseteam]

lol 2 years and counting xD

[mgallien]

@Fuseteam sorry for the extra long delay
I could never really find time to work on this
sorry to ask again (unless I missed if)
what would be still needed to have automated update for AppImage ?
let me then keep an active eye on this to ensure we eventually get all of this done

[mgallien]

given that the deployment on some proper place to distribute update packages would happen when we do a release similar to what we need to do with sparkle framework on macOS
we can look into modifying our release steps to take this into account (no matter if that is automated or not)
see for example #2599

[Fuseteam]

@Fuseteam sorry for the extra long delay I could never really find time to work on this sorry to ask again (unless I missed if) what would be still needed to have automated update for AppImage ? let me then keep an active eye on this to ensure we eventually get all of this done

i think this is supposed to fix it, i believe all we need is to get the zsync file uploaded so that the appimage is able to download just the delta on its own. This PR should do that if memory serves

[Fuseteam]

granted i have moved on to use the snap version as that has automatic updates out of the box. I moved on in part because appimages rely on fuse2 library which has been unmaintained for years at this point (fuse3 is already out) and some distros have begun not shipping fuse2 out of the box. the snap is community maintained, but if you guys would like to incorporate it in the release steps that would be nice too.

That said i'm willing to see this pr to the end

[mgallien]

@Fuseteam with regard to Linux, the only currently official package format is AppImage because that was supposed to be able to run anywhere
thanks for letting me know that this may have to change in the future
up to now, all other packages are supported by us but run by the community as they wish and on their own
I will check the current state of the AppImage update mechanism and come back here soon