Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace QString() with QStringLiteral() for better performance #7422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: replace QString() with QStringLiteral() for better performance #7422

wants to merge 1 commit into from
+144 −144

Conversation

Integral-Tech
Copy link

No description provided.

@Integral-Tech Integral-Tech force-pushed the qstring-refactor branch 3 times, most recently from 0772c18 to e81a0d2 Compare October 28, 2024 15:18
@claucambra claucambra added this to the 3.16.0 milestone Nov 22, 2024
@Integral-Tech
Copy link
Author

@claucambra Would you like to approve my PR?

mgallien
mgallien requested changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution
see my single comment requesting a change
did you do it manually ?
did you instead used a tool ?
I would suggest you have a look at Clazy unless you are already aware of it

src/gui/tray/activitylistmodel.cpp Outdated Show resolved Hide resolved
@Integral-Tech
Copy link
Author

@mgallien Done :)

@Integral-Tech Integral-Tech requested a review from mgallien January 8, 2025 16:37
@mgallien
Copy link
Collaborator

@Integral-Tech sorry for the delay
can you rebase on top of master branch ?
we up to now aim for most possibly linear history
so we would rather git rebase origin/master than git merge origin/master

mgallien
mgallien requested changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use rebase instead of merge ?
this is the intended workflow for this repository

@Integral-Tech Integral-Tech force-pushed the qstring-refactor branch 3 times, most recently from 074cdf6 to 1b5aa66 Compare January 11, 2025 02:59
@Integral-Tech
Copy link
Author

@mgallien Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siblount siblount siblount left review comments

@mgallien mgallien mgallien requested changes

@claucambra claucambra Awaiting requested review from claucambra

@camilasan camilasan Awaiting requested review from camilasan

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Integral-Tech @mgallien @siblount @claucambra