Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix path of sync run log file #7661

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

fix path of sync run log file #7661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/gui/syncrunfilelog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@ void SyncRunFileLog::start(const QString &folderPath)
{
const qint64 logfileMaxSize = 10 * 1024 * 1024; // 10MiB

const QString logpath = QStandardPaths::writableLocation(QStandardPaths::AppDataLocation);
const QString logpath =
!Utility::isWindows()
? QStandardPaths::writableLocation(QStandardPaths::AppConfigLocation)
: QStandardPaths::writableLocation(QStandardPaths::AppDataLocation);
Comment on lines +35 to +38
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to special case windows ?

Copy link
Contributor Author

@kaikli kaikli Dec 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the way how the configPath is generated in src/libsync/configfile.cpp#L366 and Windows stores everything to the data location instead of the config location.

This solves the problem that the migration tries to move the config directory from $XDG_DATA_DIR to $XDG_CONFIG_DIR and then writes the sync run logs to the data location again. This throws a log warning for each application startup.

But I think we can also use ConfigFile::logPath() from src/libsync/configfile.cpp#L1114 instead.

But I would still prefer to use the second PR #7665 to solve this problem, because log files should not be written to a config location.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaikli I was away for some time
I will try to look again at this soon.
I am not sure about the move for log files as many users might find themselves lost when their log files move to another folder. I understand that some people have a strong opinion on the location of file but I am not sure if the impact on users will be positive overall.

if(!QDir(logpath).exists()) {
QDir().mkdir(logpath);
}
Expand Down