Repository navigation
Conversation
Assisted-by: ClaudeCode:claude-opus-5.5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>
SystemKeeper
reviewed
Nov 6, 2026
Comment on lines
+173
to
+177
| public static func instanceFileId(fromLink link: String) -> String? { | ||
| let activeAccount = NCDatabaseManager.sharedInstance().activeAccount() | ||
|
|
||
| return self.instanceFileId(fromLink: link, serverUrl: activeAccount.server) | ||
| } |
Collaborator
There was a problem hiding this comment.
Since we try to remove/reduce the usage of activeAccount, I wonder if we should remove that helper method and rely on the one below
| public static func openFileInNextcloudApp(fileId: String) { | ||
| let activeAccount = NCDatabaseManager.sharedInstance().activeAccount() | ||
|
|
||
| // Since https://github.com/nextcloud/ios/pull/3983 the Files app ignores the path and looks the file up by the id at the end of the link |
Collaborator
There was a problem hiding this comment.
Should we then go ahead and change the method to remove the path completely? I don't see a point of keeping it then?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tapping a link to a file or folder on the user's server now opens it in the Nextcloud Files app when it's installed, the same way links to rooms open in Talk. Without the Files app, links keep opening in the browser.
Recognised links (with or without
/index.php){server}/f/{id}{server}/apps/files/files/{id}?dir=…{server}/apps/files/?dir=…&fileid={id}🤖 AI (if applicable)