Repository navigation
Conversation
The share helper posted to a relative `ocs/v2.php` URL, which resolves to `/index.php/apps/files/ocs/v2.php` from the Files app, so every call failed and the tests created the link through the share sidebar instead. The Vue 3 sidebar on server master (nextcloud/server#66380) renders the copy action as a link, so the fallback no longer finds it. Post to `/ocs/v2.php` so the API call works on stable31, stable32 and master, and drop the sidebar fallback. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playwright on server master fails both public share tests since nextcloud/server#66380 (for example https://github.com/nextcloud/whiteboard/actions/runs/42303232006/job/128186034990). They wait for a "Copy public link" button, and the Vue 3 sharing sidebar renders it as a link now.
The tests only reached the sidebar because the API call before it never worked: it posted to the relative
ocs/v2.php/..., which from the Files app resolves to/index.php/apps/files/ocs/v2.php/.... The helper now posts to/ocs/v2.php/..., ascreateUserShareinplaywright/support/utils.tsalready does, and the sidebar fallback is gone. The share API is the same on stable31, stable32 and master, so the tests no longer depend on the sidebar markup.Tests: on a local master container, the old helper fails both tests at the copy button, and the new one passes them with one share request each. Both also pass on local stable31 and stable32 containers.
AI