Update vsc_calcua - simplify all the things #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies the structure of this config by allowing the appropriate values for each partition/queue to be selected automatically. The general profile `vsc_calcua` now defaults to the Slurm scheduler. For local execution mode on a single node, a sub-profile `single_node` needs to be appended. Regardless of the type of executor, the current Slurm partition name is read out from the environment variables. Based on this, the correct settings (mem, cpu, time limits and queue) are applied. For single node execution mode, the resource limits are still read out dynamically. For Slurm execution, they are based on the node type. The slurm profile that allowed tasks to be submitted across different partiions was removed, because it was a hassle to debug and configure. I.e. note for future attempts: are task.mem-type values re-read for each task or only on launch of the profile?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the feedback in the previous PR (thanks @jfy133 and @nvnieuwk ) and inspired by the config for the UGent VSC, I've tried to simplify the CalcUA config.
See the commit messages for a full breakdown, but briefly: