Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail instead of warn, when nextflow help doesn't work #23

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Fail instead of warn, when nextflow help doesn't work #23

merged 1 commit into from
Oct 11, 2023

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Oct 11, 2023

While testing the AWS-based runners, this action repeatedly failed quietly, because Java was not installed, leading to not helpful error messages downstream: https://github.com/nf-core/modules/actions/runs/6480150371/job/17595232020

This change should at least stop the GHA when nextflow can't run.

@mashehu mashehu requested a review from edmundmiller October 11, 2023 14:33
edmundmiller
edmundmiller approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for adding this!

@edmundmiller edmundmiller mentioned this pull request Oct 11, 2023
Open
@edmundmiller edmundmiller merged commit 441990d into nf-core:master Oct 11, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundmiller edmundmiller edmundmiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mashehu @edmundmiller