Add API cooldown #31
Merged
Add API cooldown #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitHub actions API changes the underlying type structure to allow for plugins like the throttling plugin at v6, so update to that version.
These tests are no longer used since the switch to OctokitWrapper, and conflict with packages required for the implementation of throttling, so remove them.
|
I created a branch with a built version of this PR that should allow anyone to test it in their workflows. - name: Install Nextflow
uses: MillironX/setup-nextflow@octokit-throttling-dist
with:
version: ${{ matrix.NXF_VER }} |
Closed
|
With no objections, I will plan to merge this and tag a new version this weekend. |
|
Looked good to me, couldn't get around to making a stress test last week. We'll see if anything breaks! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A temporary solution to #19, until we can swap out OctoKit with our own API.
GitHub has a plugin that automatically backs off on OctoKit requests based on the retry headers. There were a few internals and dependencies that needed to be rearranged for it to work, but everything seems to have stayed the same on my end.
@edmundmiller, I would love for you to open a pull request on sarek, or modules or something ridiculously big like that, stuff the action workflow full of nextflow versions to test against, point to this branch, and see if the cooldown functionality actually works. I'll do the same on my (much smaller) pipelines.