removed duplicate function, search function refactor

ngageoint · Jan 5, 2024 · 70eca32 · 70eca32
1 parent 34ba1c0
commit 70eca32
Showing 1 changed file with 14 additions and 16 deletions.
diff --git a/web-app/src/ng1/factories/user-paging.service.js b/web-app/src/ng1/factories/user-paging.service.js
@@ -144,23 +144,21 @@ function UserPagingService(UserService, $q) {
     return users;
   }
 
-  function search(data, userSearch) {
-    const previousSearch = data.searchFilter;
-
-    if (previousSearch === '' && userSearch === '') {
-      return performNoSearch(data);
-    } else if (previousSearch !== '' && userSearch === '') {
-      return clearSearch(data);
-    } else if (previousSearch === userSearch) {
-      return continueExistingSearch(data);
-    } else {
-      return performNewSearch(data, userSearch);
-    }
-  }
+ function search(data, userSearch) {
+   const previousSearch = data.searchFilter;
+
+   switch (true) {
+     case previousSearch === '' && userSearch === '':
+       return performNoSearch(data);
+     case previousSearch !== '' && userSearch === '':
+       return clearSearch(data);
+     case previousSearch === userSearch:
+       return continueExistingSearch(data);
+     default:
+       return performNewSearch(data, userSearch);
+   }
+ }
 
-  function performNoSearch(data) {
-    return $q.resolve(data.pageInfo.items);
-  }
 
   function performNoSearch(data) {
     return $q.resolve(data.pageInfo.items);