Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch SnippetsFilters when feature is enabled and add to graph #2519

Conversation

kate-osborn
Copy link
Contributor

@kate-osborn kate-osborn commented Sep 6, 2024

Proposed changes

Add SnippetsFIlter to the graph. This is the first part of #2417 and unblocks #2416

Problem: SnippetsFilters need to be in graph before we can write status to them.

Solution: Register controller for SnippetsFilter when the flag --snippets-filter is set. Add SnippetsFilter to graph so we can write its status. Validate SnippetsFilter.

Testing: Tested the --snippets-filter flag with helm and manifests. Verified that the SnippetsFilters are added to the graph via logs.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

None

@kate-osborn kate-osborn requested review from a team as code owners September 6, 2024 17:12
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request helm-chart Relates to helm chart labels Sep 6, 2024
@kate-osborn kate-osborn requested a review from sjberman September 6, 2024 18:27
@kate-osborn kate-osborn requested a review from bjee19 September 9, 2024 15:41
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work! 🚀

@kate-osborn kate-osborn merged commit b554d46 into nginx:feature/snippets-filter Sep 9, 2024
41 checks passed
kate-osborn added a commit that referenced this pull request Sep 24, 2024
Problem: SnippetsFilters need to be in graph before we can write status to them.

Solution: Register controller for SnippetsFilter when the flag --snippets-filter is set. Add SnippetsFilter to graph so we can write its status. Validate SnippetsFilter.
salonichf5 pushed a commit that referenced this pull request Oct 8, 2024
Problem: SnippetsFilters need to be in graph before we can write status to them.

Solution: Register controller for SnippetsFilter when the flag --snippets-filter is set. Add SnippetsFilter to graph so we can write its status. Validate SnippetsFilter.
salonichf5 pushed a commit that referenced this pull request Oct 8, 2024
Problem: SnippetsFilters need to be in graph before we can write status to them.

Solution: Register controller for SnippetsFilter when the flag --snippets-filter is set. Add SnippetsFilter to graph so we can write its status. Validate SnippetsFilter.
sjberman pushed a commit that referenced this pull request Oct 8, 2024
Problem: SnippetsFilters need to be in graph before we can write status to them.

Solution: Register controller for SnippetsFilter when the flag --snippets-filter is set. Add SnippetsFilter to graph so we can write its status. Validate SnippetsFilter.
salonichf5 pushed a commit that referenced this pull request Oct 8, 2024
Problem: SnippetsFilters need to be in graph before we can write status to them.

Solution: Register controller for SnippetsFilter when the flag --snippets-filter is set. Add SnippetsFilter to graph so we can write its status. Validate SnippetsFilter.
sjberman pushed a commit that referenced this pull request Oct 9, 2024
Problem: SnippetsFilters need to be in graph before we can write status to them.

Solution: Register controller for SnippetsFilter when the flag --snippets-filter is set. Add SnippetsFilter to graph so we can write its status. Validate SnippetsFilter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request helm-chart Relates to helm chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants