Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace promlog with go-kit #6052

Merged
merged 2 commits into from
Jul 24, 2024
Merged

replace promlog with go-kit #6052

merged 2 commits into from
Jul 24, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jul 24, 2024 •
edited
Loading

Proposed changes

recent prometheus-common version cause issues with go linter & tests, replace the promlog logging library with go-kit, a similar logger with the same interface.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner July 24, 2024 10:03
@github-actions github-actions bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jul 24, 2024
@vepatel vepatel linked an issue Jul 24, 2024 that may be closed by this pull request
Update nginx go client and prometheus common libs #6032
Closed
@pdabelf5 pdabelf5 self-assigned this Jul 24, 2024
vepatel
vepatel reviewed Jul 24, 2024
View reviewed changes
go.mod Show resolved Hide resolved
@pdabelf5 pdabelf5 merged commit 9cb9b3e into main Jul 24, 2024
81 checks passed
@pdabelf5 pdabelf5 deleted the promlog-replacement branch July 24, 2024 12:59
nginx-bot pushed a commit that referenced this pull request Jul 24, 2024
@pdabelf5 @web-flow
replace promlog with go-kit (#6052)
30187f6
@vepatel vepatel removed a link to an issue Aug 14, 2024
Update nginx go client and prometheus common libs #6032
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel left review comments

@shaun-nx shaun-nx shaun-nx approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@haywoodsh haywoodsh haywoodsh approved these changes

Assignees

@pdabelf5 pdabelf5

Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pdabelf5 @haywoodsh @vepatel @AlexFenlon @shaun-nx