Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make docs to code gen #6360

Merged
merged 13 commits into from
Sep 10, 2024
Merged

Add make docs to code gen #6360

merged 13 commits into from
Sep 10, 2024

Conversation

j1m-ryan
Copy link
Contributor

@j1m-ryan j1m-ryan commented Sep 5, 2024

Proposed changes

Add make target to the docs makefile for the ci
Call that make target in the ci to ensure the docs build

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested review from a team as code owners September 5, 2024 09:14
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6360/

Copy link

github-actions bot commented Sep 10, 2024

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@j1m-ryan
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

1 similar comment
@vepatel
Copy link
Contributor

vepatel commented Sep 10, 2024

I have hereby read the F5 CLA and agree to its terms

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.20%. Comparing base (da69775) to head (7da7819).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6360      +/-   ##
==========================================
- Coverage   53.23%   53.20%   -0.03%     
==========================================
  Files          81       82       +1     
  Lines       16002    16002              
==========================================
- Hits         8518     8514       -4     
- Misses       7079     7081       +2     
- Partials      405      407       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jjngx
Copy link
Contributor

jjngx commented Sep 10, 2024

I have hereby read the F5 CLA and agree to its terms

@j1m-ryan j1m-ryan enabled auto-merge (squash) September 10, 2024 14:52
@j1m-ryan j1m-ryan merged commit e3e0b33 into main Sep 10, 2024
80 checks passed
@j1m-ryan j1m-ryan deleted the chore/add-make-docs-to-codegen branch September 10, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

5 participants