Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unprivileged port validation #7034

Merged
merged 8 commits into from
Jan 6, 2025

Merge branch 'main' into port-validation

5c9d990
Select commit
Loading
Failed to load commit list.
Merged

Add unprivileged port validation #7034

Merge branch 'main' into port-validation
5c9d990
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 6, 2025 in 1s

52.74% (-0.05%) compared to 93eec0d

View this Pull Request on Codecov

52.74% (-0.05%) compared to 93eec0d

Details

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Project coverage is 52.74%. Comparing base (93eec0d) to head (5c9d990).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
cmd/nginx-ingress/flags.go 0.00% 4 Missing ⚠️
internal/validation/validation.go 75.00% 2 Missing and 1 partial ⚠️
pkg/apis/dos/validation/dos.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7034      +/-   ##
==========================================
- Coverage   52.79%   52.74%   -0.05%     
==========================================
  Files          89       89              
  Lines       20827    20831       +4     
==========================================
- Hits        10996    10988       -8     
- Misses       9376     9384       +8     
- Partials      455      459       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov