-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update from nginxinc to nginx #7103
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7103 +/- ##
=======================================
Coverage 52.76% 52.77%
=======================================
Files 89 89
Lines 20831 20831
=======================================
+ Hits 10992 10994 +2
+ Misses 9382 9380 -2
Partials 457 457 ☔ View full report in Codecov by Sentry. |
@@ -8,7 +8,7 @@ F5 NGINX Ingress Controller adheres to the support policy detailed in the follow | |||
|
|||
After opening a support ticket, F5 staff will request additional information to better understand the problem. | |||
|
|||
The [nginx-supportpkg-for-k8s](https://github.com/nginxinc/nginx-supportpkg-for-k8s) plugin collects the information needed by F5 Technical Support to assist with troubleshooting your issue. | |||
The [nginx-supportpkg-for-k8s](https://github.com/nginx/nginx-supportpkg-for-k8s) plugin collects the information needed by F5 Technical Support to assist with troubleshooting your issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this being migrated as part of this project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not that I know of, reverting
- Operator -- https://github.com/nginxinc/nginx-ingress-helm-operator | ||
- Configuration examples -- https://github.com/nginx/kubernetes-ingress/tree/{{version}}/examples | ||
- Helm Chart -- https://github.com/nginx/kubernetes-ingress/tree/{{version}}/deployments/helm-chart | ||
- Operator -- https://github.com/nginx/nginx-ingress-helm-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the helm operator part of this migration project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not initially, I'll revert the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc changes LGTM.
@@ -26,15 +26,15 @@ The plugin may collect some or all of the following global and namespace-specifi | |||
|
|||
This plugin **does not** collect secrets or coredumps. | |||
|
|||
Visit the [project’s GitHub repository](https://github.com/nginxinc/nginx-supportpkg-for-k8s) for further details. | |||
Visit the [project’s GitHub repository](https://github.com/nginx/nginx-supportpkg-for-k8s) for further details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another reference to nginx-supportpkg-for-k8s
Proposed changes
Updates references from
nginxinc
Checklist
Before creating a PR, run through this checklist and mark each as complete.