Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken url in compile-waf-policies.md #7110

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

nginx-aoife
Copy link
Contributor

Proposed changes

Issue detected by docs test Automation.
Fix broken link to App Protect in NIM.
NIM doc reorganisation and recent clearing of Azure cache is the likely cause of this broken link.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Fix a broken link to NIM docs

Signed-off-by: nginx-aoife <[email protected]>
@nginx-aoife nginx-aoife added documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch labels Jan 10, 2025
@nginx-aoife nginx-aoife requested review from a team as code owners January 10, 2025 14:15
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7110/

@nginx-aoife nginx-aoife merged commit 52a59c1 into main Jan 10, 2025
30 checks passed
@nginx-aoife nginx-aoife deleted the bug-fix-nim-link branch January 10, 2025 16:32
nginx-bot pushed a commit that referenced this pull request Jan 10, 2025
Update compile-waf-policies.md

Fix a broken link to NIM docs

Signed-off-by: nginx-aoife <[email protected]>
nginx-aoife added a commit that referenced this pull request Jan 10, 2025
Fix broken url in compile-waf-policies.md (#7110)

Update compile-waf-policies.md

Fix a broken link to NIM docs

Signed-off-by: nginx-aoife <[email protected]>
Co-authored-by: nginx-aoife <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants