Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes Several Issues. #68

Closed
wants to merge 17 commits into from
Closed

Closes Several Issues. #68

wants to merge 17 commits into from

Conversation

axle2005
Copy link

@axle2005 axle2005 commented Jun 29, 2017

Closes Issue #63 #66 #50 #54 #44

Commit f376de9 - Added a simple permission check to check if player had nucleus.connectionmessages.disable and return if true.

Commit 336c4f9 - Added method setDescription to ChannelUtil and added to GameStoppingServerEvent event.

Commit bb73f49 - Added new variable, playerCount. Increases and decreases as clients connect. Updates description using previous commit.

Commit 063ac85 - Added a check for Discord messages starting with '!', using as an escape character to create discord commands.

Commit d74003e - I screwed up making a package on the previous commit :P Shit happens lol

Commit 0e9409f - Added 'removeColor' method to strip minecraft color codes from any message sent to discord.

Commit 0b44d8f - Added Support for 'Boop'. Creates 'hooks' package for future support of plugins.

Commit d743f3a - Moved the string for the Nucleus Staff channel to Nucleus class in hooks package created in previous commit.

@Mohron
Copy link
Contributor

Mohron commented Jun 29, 2017

I'm going to borrow some of this for my fork if you don't mind :D

@@ -32,7 +32,7 @@
* Created by Hy on 1/4/2016.
*/
@Plugin(id = "discordbridge", name = "Discord Bridge", version = "2.3.0",
description = "A Sponge plugin to connect your Minecraft server with Discord", authors = {"Hy", "Mohron"})
description = "A Sponge plugin to connect your Minecraft server with Discord", authors = {"Hy", "Mohron, Axle2005"})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One PR makes you an Author? Interesting...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly :P If he wants to deny this one commit, I don't care. The rest of the PR is good, but I'm still going to be hobbling along on this plugin anyway.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just think it's funny when contributors add themselves.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time for another commit then: Instead of author, Grand Pumba of Randomness

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMAO.

@axle2005 axle2005 changed the title Closes Issue #63 and Issue #66 Closes Issue #63 #66 and #50 Jun 30, 2017
@axle2005 axle2005 changed the title Closes Issue #63 #66 and #50 Closes Issue #63 #66 #50 and #54 Jul 1, 2017
@axle2005 axle2005 changed the title Closes Issue #63 #66 #50 and #54 Closes Several Issues. Jul 1, 2017
@Mohron
Copy link
Contributor

Mohron commented Jul 7, 2017

Recommend splitting discord commands and Twitter support to their own PRs. Also if you would update the Readme and example configs with documentation of your additions.

@axle2005
Copy link
Author

axle2005 commented Jul 7, 2017

Well, Ill do some splitting and resubmit.

@axle2005 axle2005 closed this Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants