Raise NHS::PDS::TooManyMatches
#2758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvararu
approved these changes
Dec 16, 2024
thomasleese
force-pushed
the
too-many-matches
branch
from
26a2c9a to
e99edb0
Compare
thomasleese
force-pushed
the
too-many-matches
branch
from
e99edb0 to
facbf41
Compare
misaka
approved these changes
Dec 18, 2024
misaka
approved these changes
Dec 18, 2024
thomasleese
force-pushed
the
too-many-matches
branch
from
facbf41 to
49d8501
Compare
thomasleese
force-pushed
the
too-many-matches
branch
from
49d8501 to
0abdc8c
Compare
thomasleese
force-pushed
the
too-many-matches
branch
3 times, most recently
from
3fdb99f to
ce197e2
Compare
thomasleese
force-pushed
the
too-many-matches
branch
2 times, most recently
from
452bfca to
f389b43
Compare
This updates the PDS search client code to handle getting a too many matches error response and raise a suitable exception. This doesn't handle the error, as we need to decide how to handle this case, but having its own error means we can easily filter these out in Sentry.
thomasleese
force-pushed
the
too-many-matches
branch
from
f389b43 to
3356155
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the PDS search client code to handle getting a too many matches error response and raise a suitable exception.
This doesn't handle the error, as we need to decide how to handle this case, but having its own error means we can easily filter these out in Sentry.