Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

Dual algo profit switching #919

Merged
merged 7 commits into from
Jun 6, 2017
Merged

Dual algo profit switching #919

merged 7 commits into from
Jun 6, 2017

Conversation

DillonN
Copy link
Contributor

@DillonN DillonN commented May 24, 2017

This adds support for NHM to automatically switch the four different states of ClaymoreDual (just dagger plus dagger with three secondary coins) based on the profitability. The other three types of ClaymoreDual come up as their own miners (disabled by default) named as "DaggerDecred" etc. To keep UI modifications minimal I did not add any columns for secondary speed/profit, it is just displayed in the normal columns as [Daggerspeed]/[Secondaryspeed]. There is a new text box in the algo settings to change secondary speed though.

The API will get the correct data and show it on the main screen, however the string gets too long and cut into by "Rate". I'm not sure if this is just my system because it is high-DPI, but I cannot edit anything using the designers as it completely fudges up the numbers for everything else.

For technical details, I added the ability for an Algorithm object to contain a secondary algo type and speed. In order to not mess too much with the profit switching logic I also added a method that returns a tandem algo index, which are defined in the AlgorithmType enum as -5,-4,-3. This allows the profit switching to see the miners as different since they have the same base type and main algorithm type (dagger).

Benchmarking also works almost completely. Only problem is Claymore stops running if benchmark mode is off after around 2min if redirect output is true. It can't run in benchmark mode since only the ETH speeds are displayed.

I've been running this for around 2 weeks on my own personal rigs and there doesn't seem to be any problems. I do have multi card systems however I don't have any identical cards so I haven't tested that, but it should work fine as I updated the average logic to support the secondary speeds. It does really help to have it switch since Decred and Pascal are all over the place lately.

DillonN added 7 commits May 24, 2017 12:18
Updated config to support dual algos

Enable launching of dual algos

Add all dual algo types
Functional UI speed setting

Polish of UI

Added localization strings
Fixed benchmarking
Work on profit switching
fix

more cleanup

Grouping fix

cleanup
@MikeBuzz
Copy link

Could SIA support be added to this

@DillonN
Copy link
Contributor Author

DillonN commented May 24, 2017

Oh I didn't notice SIA had been added to NiceHash. It wouldn't be hard to activate SIA dual mining once there is support for it in NHM at all, but that has to be there first.

@MikeBuzz
Copy link

They added it as a mining option but not in the software yet, i believe it needs an update version of claymore, which should be available in the next 24hrs

@DillonN
Copy link
Contributor Author

DillonN commented May 24, 2017

Yeah, there needs to be support for it in the software first before I can add it as a dual algo though. I could do it now but I'm pretty sure there will be official support soon anyway.

@MikeBuzz
Copy link

Not 100% sure there will be any more release on the 1.7 branch now that they are working on v2

Thanks for the PR hope it gets merged soon :)

@DillonN
Copy link
Contributor Author

DillonN commented May 25, 2017

Thanks!

@S74nk0 S74nk0 merged commit 2191c55 into nicehash:master Jun 6, 2017
@S74nk0
Copy link
Contributor

S74nk0 commented Jun 6, 2017

@DillonN Thanks for the contribution.

@S74nk0
Copy link
Contributor

S74nk0 commented Jun 6, 2017

@DillonN v1.7.5.13

@lukasmagi
Copy link

No support of dual mining for nVidia cards ....WHY ?? (ClaymoreDual for ETH too - Genoil Miner is unstable if you have more than 3+ cards in rig )

@DillonN DillonN deleted the dualprofit branch June 6, 2017 21:49
@DillonN
Copy link
Contributor Author

DillonN commented Jun 7, 2017

@lukasmagi Check out #985

@imrecsoka
Copy link

Hi and thanks for the this DillonN, but how do you use the feature, I know its a silly question.
Do you just press start in NHM and let it do its thing?

@computeronix
Copy link

@imrecsoka go into your GPU and you will see the additional algorithms, enable them, benchmark and then if more profitable (should be) it will use them for you automatically

@DillonN Thank you so much this works quite nicely!! Amazing job!

Also wanted to call out the following display item (which I am sure has already been discussed)

Other than this, working quite nicely

image

@DillonN
Copy link
Contributor Author

DillonN commented Jun 7, 2017

@computeronix thanks for the good instructions and support!

Yes I know of the clipping unfortunately I can't do too much UI editing because my version of Visual Studio messes up the whole UI when changing anything

@imrecsoka
Copy link

imrecsoka commented Jun 7, 2017

I have benchmarked everything that works for AMD, some items failed which i suppose i cant do bugger all about , right?

So assume i just press start now and that is that?
Nothing rocket science i need to do?

3)To me the end-user, it seems just like the previous version, but if i understand correctly there is more intelligence built in to the profit-checking mechanism ?

I really am a small fish but i am willing to donate to you guys:
please send me your btc addresses:
@computeronix and @DillonN
Thanks

@DillonN
Copy link
Contributor Author

DillonN commented Jun 7, 2017

Yes if you've done a benchmark again pressing start should do it.

Did any of the new entries such as "DaggerDecred" fail?

There is some more intelligence in that it will take into account both the price of Eth as well as the secondary coin

@imrecsoka
Copy link

yes that one failed for me:
i have reset nhm and redone it all again with default settings:
image

do you want me to do all algorithms? and screen shot those for u ?

@DillonN
Copy link
Contributor Author

DillonN commented Jun 7, 2017

So DaggerDecred fails? I can look into this more when I get home but try posting your logs

@imrecsoka
Copy link

i will get to this some time, sorry i have been very busy and ill with winter hitting us here.

@computeronix
Copy link

No problem! Stay safe and good luck with winter!

@WhiteG00se
Copy link

why is there no option for zcash/ethereum dual mining?

@HyperCriSiS
Copy link

The DaggerHashimoto has only 3.5 MH/s on my GTX970, is this normal?

@ghost
Copy link

ghost commented Jun 20, 2017

@computeronix like @HyperCriSiS , i too am running a GTX970 with Windows 10 (64bit). the issue i'm having is a "Stratum_Subscribe timed out" error. For my drivers, i'm currently on the latest which is 382.53. @HyperCriSiS , what version drivers are you on?

I'm honestly not sure what else to share since i'm green at this.

capture

@DillonN
Copy link
Contributor Author

DillonN commented Jun 20, 2017

It looks like the miner can't reach the NiceHash servers, try disabling your firewall temporarily and see if that fixes it. Miner programs are often given a lot of shit by firewalls/antivirus since people like to use them in viruses (mine unknowingly on people's computers)

@DillonN
Copy link
Contributor Author

DillonN commented Jun 20, 2017

@HyperCriSiS I'm not familiar with how a 970 does but I believe that is below the normal. What driver/OS are you using? Claymore has expressed some issues with newest drivers on Win10. Unfortunately the only Maxwell card I have to try is a 970m in my laptop

@HyperCriSiS
Copy link

HyperCriSiS commented Jun 20, 2017

Some people in the Gaco Mod repository told me that the GTX970 is not good for ETH mining.

@DillonN
Copy link
Contributor Author

DillonN commented Jun 20, 2017

No I don't believe it is

Some of the more NVIDIA friendly algos like Equihash, Lbry etc are paying well right now so I wouldn't worry about it

@candrews
Copy link

candrews commented Jun 20, 2017 via email

@HailHEN
Copy link

HailHEN commented Jun 23, 2017

@DillonN Quick question. I am currently Dual Mining DaggerhashDecred and the profitability varies by $3 usd a day on the GUI and website. Which one do I use?? Or does the GUI not take into account the second algorithm. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants