Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for failing linking to project search #147

Merged
merged 11 commits into from
Jul 11, 2024
Merged

Hotfix for failing linking to project search #147

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
731d0bf
removed immediate watch to avoid overlapping fetching
ignapas Jun 26, 2024
27d9908
Merge branch 'main' into project-filters-hotfix
ignapas Jul 2, 2024
323d46f
url building
ignapas Jul 2, 2024
4e50575
fetching styles in beformount to avoid immediate consortiatype watche…
ignapas Jul 2, 2024
661c9f2
Merge branch 'main' into project-filters-hotfix
ignapas Jul 3, 2024
3e6cbc1
migrated hook to vue 3 syntax
ignapas Jul 3, 2024
d2cf04e
Merge branch 'main' into project-filters-hotfix
ignapas Jul 10, 2024
fc2953e
reverted changes in filestable
ignapas Jul 10, 2024
beb74af
final fix?
ignapas Jul 10, 2024
c00bc18
emitting change even if there are no facets selected
ignapas Jul 10, 2024
27451d5
Merge branch 'main' into project-filters-hotfix
ignapas Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions pages/about/projects/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ export default {
// Added route name check bc clicking on Data & Models header link was causing this to still fire after navigating to the data page
if (!this.$route.query.consortiaType && this.$route.name == 'about-projects') {
this.$router.push({
query: {consortiaType: this.consortiaType['id'] }
query: {consortiaType: this.consortiaType.id }
})
} else {
this.searchData = {
Expand All @@ -291,20 +291,17 @@ export default {
handler: function () {
this.searchQuery = this.$route.query.search
this.fetchResults()
},
immediate: true
}
},
'$route.query.projectsSort': {
handler: function (option) {
this.fetchResults()
},
immediate: true
}
},
'$route.query.selectedProjectsAnatomicalFocusIds': {
handler: function (option) {
this.fetchResults()
},
immediate: true
}
},
},

Expand All @@ -321,7 +318,6 @@ export default {
limit: Number(this.$route.query.limit || this.searchData.limit),
search: this.$route.query.search || ''
}

this.searchData = { ...this.searchData, ...queryParams }
}
if (window.innerWidth <= 768) this.titleColumnWidth = 150
Expand Down
Loading