-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display biolucida images in gallery based on scicrunch #152
Display biolucida images in gallery based on scicrunch #152
Conversation
Passing run #148 ↗︎
Details:
Review all test suite changes for PR #152 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is right since there does appear to be images for those gallery items, for example:
Ah nvm I just read the comments you posted on the Wrike ticket. So ideally once scicrunch has been updated then the images would show again in the gallery, correct? |
Yes, that's right. As long as related Biolucida metadata is updated in Scicrunch, images will show again. The function still uses the Biolucida data to generate gallery image items. Just added one more filtering step to check if these images exist on Scicrunch. |
@ddjnw1yu A more complete solution is to use the Scicrunch response itself to build up all the biolucida image items on the gallery instead of making an extra call with |
@egauzens FYI, some datasets have a lot of biolucida images and not all of them are meant to present on the gallery so the presence of a biolucida id gives us an idea of whether a biolucida images should be present/highlighted on the gallery. |
I have taken a look at the code and had a try. We probably no need to do this. From what I saw, we will still need to call |
The latest commit uses Scicrunch data to create gallery items. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with either way we find the gallery images, it does look cleaner just getting from scicrunch and so long as it seems about the same computationally then I'm ok with this
For sprint ticket - Bug Submission: Image viewer not opening
This should help to hide the biolucida image whose id does not exist in Scicrunch.