Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default flatmap to human #205

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Change the default flatmap to human #205

merged 4 commits into from
Sep 20, 2024

Conversation

alan-wu
Copy link
Contributor

@alan-wu alan-wu commented Sep 20, 2024 •
edited
Loading

Change the default map to human.

I have also included couple of small changes -

  • Make sure loading screen is on top of the header items
  • Calls to get algolia facets will no longer fetch any dataset results

It can be tested here - https://alan-wu-sparc-app.herokuapp.com/

@cypress Cypress
Copy link

cypress bot commented Sep 20, 2024

SPARC Vue3 Portal Testing    Run #256

Run Properties:  status check passed Passed #256  •  git commit 15ec4c5782: Small update on the test.
Project SPARC Vue3 Portal Testing
Branch Review default-human-map
Run status status check passed Passed #256
Run duration 14m 34s
Commit git commit 15ec4c5782: Small update on the test.
Committer alan-wu
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 71
View all changes introduced in this branch ↗︎

@alan-wu alan-wu requested a review from ddjnw1yu September 20, 2024 01:41
ddjnw1yu
ddjnw1yu approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@ddjnw1yu ddjnw1yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected!

@alan-wu alan-wu merged commit 266d92d into nih-sparc:main Sep 20, 2024
2 checks passed
@alan-wu alan-wu deleted the default-human-map branch November 14, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddjnw1yu ddjnw1yu ddjnw1yu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alan-wu @ddjnw1yu