Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing improvement #228

Merged
merged 116 commits into from
Nov 19, 2024
Merged

Testing improvement #228

merged 116 commits into from
Nov 19, 2024

Conversation

ddjnw1yu
Copy link
Collaborator

@ddjnw1yu ddjnw1yu commented Nov 12, 2024

Massive testing cases updates.

  • Add description for most testing cases
  • Split extensive tests into smaller pieces
  • Modify GitHub workflow YML files

See https://docs.google.com/spreadsheets/d/1NJjKRfgUGHItv3WTZajSZq3eId7IQEm6aneh6pnpWNY/edit?gid=190337595#gid=190337595 for more detail.

Light green: Previous.
Soft green: New added, and the testing process follows the description.
Dark green: New added. To satisfy the testing requirement, some processes may slightly differ from manual QC.

@ddjnw1yu
Copy link
Collaborator Author

Workflow failed because the timeout had been set to 30 minutes in the old YML file. New testing contains more tests which will use the new YML file and run in parallel.

Copy link

cypress bot commented Nov 12, 2024

SPARC Vue3 Portal Testing    Run #334

Run Properties:  status check passed Passed #334  •  git commit 585298dafd: Delete part of the graph tool testing
Project SPARC Vue3 Portal Testing
Branch Review testing-improvement
Run status status check passed Passed #334
Run duration 48m 20s
Commit git commit 585298dafd: Delete part of the graph tool testing
Committer David J. Yu
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 26
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 173
View all changes introduced in this branch ↗︎

@ddjnw1yu ddjnw1yu marked this pull request as draft November 12, 2024 04:10
@ddjnw1yu ddjnw1yu mentioned this pull request Nov 12, 2024
@ddjnw1yu ddjnw1yu requested a review from alan-wu November 12, 2024 08:06
Copy link
Contributor

@alan-wu alan-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

Same selector returns different result when run in ui/terminal/cloud, unable to create usable assertions.
@ddjnw1yu ddjnw1yu marked this pull request as ready for review November 18, 2024 23:59
@alan-wu alan-wu merged commit 2c3bc85 into nih-sparc:main Nov 19, 2024
2 checks passed
@ddjnw1yu ddjnw1yu deleted the testing-improvement branch November 19, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants