Repository navigation
http2: release memory credit for canceled writes - #66784
Open
fatihguzeldev wants to merge 2 commits into
Open
fatihguzeldev wants to merge 2 commits into
fatihguzeldev wants to merge 2 commits into
Conversation
Canceled uploads left unsent bytes charged to the session, causing later requests to fail with NGHTTP2_ENHANCE_YOUR_CALM. Release the remaining credit during deferred cleanup, before running write callbacks. Signed-off-by: Fatih Güzel <fatihguzeldev@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
pimterry
approved these changes
Oct 28, 2026
Member
|
Hi @fatihguzeldev, the core change here looks good but the CPP linting is failing, can you take a look? |
Signed-off-by: Fatih Güzel <fatihguzeldev@gmail.com>
Author
|
@pimterry thanks for the review, fixed the formatting. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66784 +/- ##
==========================================
+ Coverage 90.49% 90.66% +0.17%
==========================================
Files 797 797
Lines 277503 278485 +982
Branches 53329 53563 +234
==========================================
+ Hits 251124 252495 +1371
+ Misses 16785 16344 -441
- Partials 9594 9646 +52
🚀 New features to boost your workflow:
|
pimterry
added
the
request-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when an upload was canceled, its queued data was discarded but still counted toward the session's memory limit. that could make later requests on the same session fail with
NGHTTP2_ENHANCE_YOUR_CALM.cleanup now subtracts those bytes before running the write callbacks. the test checks both cancellation by the server and
destroy()from a write callback.Fixes: #66742