Repository navigation
deps: update v8 to 15.8 - #67070
deps: update v8 to 15.8#67070legendecas wants to merge 9 commits into
Conversation
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 15.8. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
Original commit message:
[sandbox] fix dispatch table access on illumos
illumos pointers are VA48, can allocate from the top of the 64-bit range
as well.
Co-Authored-By: Dan McDonald <danmcd@mnx.io>
Refs: nodejs#65161
Change-Id: I7d803ca0da2ab6c7cc206cb964d63683523a13da
Refs: v8/v8@011b2de
Original commit message:
Do not use preserve_most when targeting the MSVC ABI
In the Microsoft C++ ABI, because preserve_most changes the calling
convention, clang mangles it with U while cdecl gets an A, which
means components compiled with different toolchains can fail to link.
Make it a no-op when targeting MSVC and its ABI.
Co-Authored-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Refs: nodejs#55784
Change-Id: I67b49e739942d4026ac060be35bb39ec22256cbd
Refs: v8/v8@7d7e8c2
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8459484 Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8524366 Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
|
Review requested:
|
nodejs-github-bot
added
build
V8 deprecated --harmony-struct. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8610686 Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
|
The current stable train is still on 15.7 (stable release next week). Shouldn’t we update to that one? https://chromiumdash.appspot.com/schedule |
|
My 2cts on this: I would be in favor of skipping 15.7, my reasoning is:
If instead we group semver-major changes every few months, e.g. I see that V8 16.0 will be LTS and plan for December, that seems like a good candidate. |
I think the downside of following a non-stable V8 upgrade is that it generally contains bugs/regressions that are not yet caught and will only be fixed later after it is rolled out to Chrome users and noticed. As a result we need to patch it more often to fix the bugs/regressions introduced in the non-stable releases. And because we need to bump the embedder string every time we do it, every one of these incurs a V8 rebuild in the CI, the releases will invalidate previously compiled code cache, etc. If we stick to the stable release there will generally be fewer churn because they are already battle-tested by Chrome users. |
No description provided.