Repository navigation
Conversation
JSValueToSQLiteResult() passed the size_t length of returned ArrayBuffers and ArrayBufferViews to sqlite3_result_blob(), which takes an int. Buffers larger than INT_MAX bytes were narrowed, yielding silently truncated blobs or bogus empty text values. Use sqlite3_result_blob64() and sqlite3_result_text64(), matching Statement::BindValue(), so oversized values are rejected with SQLITE_TOOBIG. Assisted-by: Claude Code Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67089 +/- ##
========================================
Coverage 90.65% 90.65%
========================================
Files 797 797
Lines 278321 278798 +477
Branches 53530 53625 +95
========================================
+ Hits 252315 252750 +435
- Misses 16387 16404 +17
- Partials 9619 9644 +25
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
sqlite3_result_blob64()andsqlite3_result_text64()so buffers returned from user-defined functions that exceedINT_MAXbytes throwSQLITE_TOOBIGinstead of being silently truncated or turned into empty text.