-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduced new downloads page #7357
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm happy with the current state of the PR, thanks!
Co-authored-by: Jordan Harband <[email protected]> Signed-off-by: Claudio W <[email protected]>
Cane someone from @nodejs/web-infra approve this PR too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Looking forward to the follow-up docs PR for folks wanting to add other community options, and what constitutes an official option vs. community.
As a future improvement, would love the over-the-wire HTML to have some default selected (perhaps based on stats for the most common OS) and the snippet pre-rendered (could just be plain-text if Shiki pre-rendering is too complex).
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Yah indeed, if JS isn't available and before JS has run on the page but once the HTML has arrived (with my slow:tm: internet, I see a solid few seconds of the empty code block which I'd love to see have a default of some sort loaded instead from the start) |
I tested with slow 3g and it took 2-3 seconds, but honestly that shouldn't be a concern. The issue of having an initial codebox regardless of environment, @MattIPv4 is that it will cause a flash effect, since most likely it will show a different one once it renders, hence why the Skeleton. It would also require Shiki + Eval'ing the snippet to happen twice. My last commit was done as a performance pass meticulously 👀 the performance graphs on DevTools. |
This PR introduces the shiny new Downloads page envisioned by the package maintenance Working Group (#7037).
It also officially unblocks community members from adding package managers and installation methods to the Downloads page!
Warning!: This PR also resets all translations for the downloads page (unfortunately, as a preventive method)
Closes #7037
Closes #7296
Unblocks #6953
Unblocks #6978
Unblocks #6832
CHECK THE PREVIEW HERE