Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduced new downloads page #7357

Merged
merged 5 commits into from
Dec 28, 2024
Merged

feat: introduced new downloads page #7357

merged 5 commits into from
Dec 28, 2024

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Dec 25, 2024

This PR introduces the shiny new Downloads page envisioned by the package maintenance Working Group (#7037).

It also officially unblocks community members from adding package managers and installation methods to the Downloads page!

Warning!: This PR also resets all translations for the downloads page (unfortunately, as a preventive method)

Closes #7037
Closes #7296
Unblocks #6953
Unblocks #6978
Unblocks #6832

CHECK THE PREVIEW HERE

@ovflowd ovflowd added i18n Issues/PRs related to the Website Internationalisation website redesign Issue/PR part of the Node.js Website Redesign feature-request Requesting a new Technological Feature to be added to the Website infrastructure Issues/PRs related to the Repository Infra labels Dec 25, 2024
@ovflowd ovflowd requested review from a team as code owners December 25, 2024 02:33
Copy link

vercel bot commented Dec 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 28, 2024 3:03am

This comment has been minimized.

GeoffreyBooth

This comment was marked as resolved.

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Dec 25, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 25, 2024
@ovflowd

This comment was marked as resolved.

@ovflowd

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Dec 25, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
84.08% (597/710) 65.12% (183/281) 82.7% (110/133)

Unit Test Report

Tests Skipped Failures Errors Time
124 0 💤 0 ❌ 0 🔥 4.903s ⏱️

@MattIPv4

This comment was marked as resolved.

@ovflowd

This comment was marked as resolved.

@ljharb

This comment was marked as resolved.

Copy link
Contributor

github-actions bot commented Dec 27, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 91 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟠 89 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm happy with the current state of the PR, thanks!

apps/site/snippets/en/download/nvm.bash Show resolved Hide resolved
Co-authored-by: Jordan Harband <[email protected]>
Signed-off-by: Claudio W <[email protected]>
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Dec 27, 2024
@ovflowd
Copy link
Member Author

ovflowd commented Dec 27, 2024

Cane someone from @nodejs/web-infra approve this PR too?

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Looking forward to the follow-up docs PR for folks wanting to add other community options, and what constitutes an official option vs. community.

As a future improvement, would love the over-the-wire HTML to have some default selected (perhaps based on stats for the most common OS) and the snippet pre-rendered (could just be plain-text if Shiki pre-rendering is too complex).

@ovflowd

This comment was marked as resolved.

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
@ovflowd

This comment was marked as resolved.

@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
@ovflowd ovflowd enabled auto-merge December 28, 2024 03:05
@ovflowd ovflowd disabled auto-merge December 28, 2024 03:06
@ovflowd ovflowd merged commit 1ef006f into main Dec 28, 2024
17 checks passed
@ovflowd ovflowd deleted the feat/new-downloads-page branch December 28, 2024 03:09
@MattIPv4
Copy link
Member

You mean when JavaScript is not available

Yah indeed, if JS isn't available and before JS has run on the page but once the HTML has arrived (with my slow:tm: internet, I see a solid few seconds of the empty code block which I'd love to see have a default of some sort loaded instead from the start)

@ovflowd
Copy link
Member Author

ovflowd commented Dec 28, 2024

You mean when JavaScript is not available

Yah indeed, if JS isn't available and before JS has run on the page but once the HTML has arrived (with my slow:tm: internet, I see a solid few seconds of the empty code block which I'd love to see have a default of some sort loaded instead from the start)

I tested with slow 3g and it took 2-3 seconds, but honestly that shouldn't be a concern. The issue of having an initial codebox regardless of environment, @MattIPv4 is that it will cause a flash effect, since most likely it will show a different one once it renders, hence why the Skeleton.

It would also require Shiki + Eval'ing the snippet to happen twice. My last commit was done as a performance pass meticulously 👀 the performance graphs on DevTools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Requesting a new Technological Feature to be added to the Website i18n Issues/PRs related to the Website Internationalisation infrastructure Issues/PRs related to the Repository Infra website redesign Issue/PR part of the Node.js Website Redesign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign the Downloads page tabs to reflect on latest agreements with Package Maintenance WG
9 participants