-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Resolve ambiguity in TryGetElementType() for Mono runtime (#3395) #3399
base: main
Are you sure you want to change the base?
Conversation
c503bad
to
6cb9612
Compare
@roji |
@giritrivedi I've triggered the CI, but I'm not sure it's appropriate to merge this rather than just having it fixed on the mono side. And by the way, this specific function is a copy-paste from the EF source code, so the same problem should exist there. |
Thanks @roji. We will work on giving a fix in Mono. |
@giritrivedi OK, that's great to hear! Are you OK with me closing this PR and #3395 then? |
I will let @uweigand comment on this. |
I agree the right thing is to fix this in the runtime (note this is about the Mono flavour of the dotnet runtime, not the classic Mono standalone project). However, it may take quite a bit of time for any runtime fix to actually become available in the official releases customers are using. Therefore, we were wondering if it would be acceptable to have a workaround in this project for the time being. |
@roji Can this be merged to ensure customers do not face this issue until a better fix is provide in Mono runtime ? |
Hi @roji, As noted by @uweigand and @giritrivedi, the Mono runtime fix might take some time to be available in official releases. This workaround ensures customers are not impacted in the meantime. Since all checks have passed, would you agree to merge this PR as an interim solution while we continue working on the permanent fix in the Mono runtime? Looking forward to your thoughts. |
Summary
Fixes #3395
This PR addresses a discrepancy in the Mono runtime that adds extra generic interfaces, such as
IEnumerable<int>
, for arrays and collections. This behavior causes failures in the EFCore.PG test suite, particularly in theTryGetElementType()
logic used for interface resolution.@uweigand @giritrivedi @saitama951