Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerToys cannot use BrowseRouter to execute a web search. #55

Closed
mudnug opened this issue Nov 28, 2024 · 6 comments
Closed

PowerToys cannot use BrowseRouter to execute a web search. #55

mudnug opened this issue Nov 28, 2024 · 6 comments

Comments

@mudnug
Copy link

mudnug commented Nov 28, 2024

Wanted to let the community know that PowerToys can't always launch BrowseRouter correctly: microsoft/PowerToys#36083

@nref
Copy link
Owner

nref commented Nov 28, 2024

Hi, thanks for the report. Can you please provide BrowseRouter logs? You can find them in C:\Users\<user>\AppData\Local\BrowseRouter. Make sure the following is in your config.ini file:

[log]
enabled = true

The log contains URLs you have visited. Please take care to remove anything from the file you won't want seen publicly.

@mudnug
Copy link
Author

mudnug commented Nov 29, 2024

There are no logs from the attempt to execute a search. I expect it is purely an issue PowerToys would resolve (I just wanted to link their their issue)

@mudnug mudnug closed this as completed Nov 29, 2024
@mudnug
Copy link
Author

mudnug commented Dec 9, 2024

It turns out the error is resolved after implementing the missing quotes as mentioned in #63
"Z:\Path To\BrowseRouter\BrowseRouter.exe" %1

(As of 2024-12-08 there was a bug in the location of the quotes that will likely be fixed separately)

The error was caused by quotes missing in the registry, however, It appears the browsers accept multiple arguments by default and browser router breaks this behavior for the following feature:
BrowseRouter.exe https://example.org/ [...more URLs]

Could we add something like (brainstorming here) BrowseRouter.exe --single-argument first [more words] which can then be passed directly to the browser so that this functionality is supported?

I got --single-argument based on
https://github.com/microsoft/PowerToys/blob/main/src/modules/launcher/Wox.Plugin/Common/DefaultBrowserInfo.cs but I believe it could be named anything.

Then we would put that argument in the registry so that apps calling BrowseRouter aren't inadvertently launching multiple tabs when trying to execute a single multiword query.

@mudnug mudnug reopened this Dec 9, 2024
@mudnug mudnug changed the title Error when using PowerToys PowerToys cannot use BrowseRouter to execute a web search. Dec 10, 2024
@nref
Copy link
Owner

nref commented Jan 5, 2025

Hi @mudnug . I could add a pass through flag, but how would BrowseRouter know which browser to open? BrowseRouter.exe --single-argument first [more words] doesn't contain a URL.

Most web searches can be done by passing a query parameter e.g. https://duckduckgo.com/?q=lorem ipsum

Could you teach me how you are using PowerToys, so I could understand the pain point? Thanks.

@mudnug
Copy link
Author

mudnug commented Jan 5, 2025

This issue is with PowerToys Run. I have stopped using PowerToys Run and installed Flow Launcher, which doesn't have this issue and can call BrowseRouter in a way that web searches work.

I don't have a complete answer for you as I don't fully understand what causes the issue, but RaSan147 indicated PowerToys Run also has an issue calling Opera GX.

@nref
Copy link
Owner

nref commented Jan 7, 2025

Thanks for the update. I will close this issue. Feel free to reach out again if I can be of assistance.

@nref nref closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants