Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BrowseRouter Registration missing quotes #63

Closed
mudnug opened this issue Dec 3, 2024 · 11 comments
Closed

BrowseRouter Registration missing quotes #63

mudnug opened this issue Dec 3, 2024 · 11 comments

Comments

@mudnug
Copy link

mudnug commented Dec 3, 2024

Due to the missing quotation marks it appears that other applications may not be able to launch the app when the path contains spaces.

This is stored as the Data in key Computer\HKEY_CLASSES_ROOT\BrowseRouterURL\shell\open\command

@nref
Copy link
Owner

nref commented Dec 4, 2024

Thanks for the report. I will fix this in the next few days, or accept a PR.

@mudnug
Copy link
Author

mudnug commented Dec 4, 2024

Thank you. I'm still trying to work out what the mechanism is that PowerToys uses to trigger searches (which no longer works with BrowseRouter configured as default) The missing quotes was the first thing I came across. I'm not 100% sure on what the quotes should be and I don't know what specification to consult in relation to that.

@mudnug
Copy link
Author

mudnug commented Dec 4, 2024

When I use
"Z:\Path To\BrowseRouter\BrowseRouter.exe" %1
The browser will launch, but if I use A Search Query in PowerToys, It ends up launching three separate tabs as if each of the words A Search Query was a separate URL.

@nref
Copy link
Owner

nref commented Dec 7, 2024

Fixed in the linked PR and released as https://github.com/nref/BrowseRouter/releases/tag/0.13.1. Would you mind to see if it resolves the issue with PowerToys?

image

@mudnug
Copy link
Author

mudnug commented Dec 7, 2024

What's the procedure for me to test this? Would I need to unregister and then register again and then make sure it is set as default in Windows settings?

@nref
Copy link
Owner

nref commented Dec 8, 2024

Good question. Just double-click the exe and it will update the existing registry keys with the new quoted path.

@mudnug
Copy link
Author

mudnug commented Dec 9, 2024

Following your steps the app did update the registry.

This breaks double clicking on .URL files for me (as well as PowerToys not working).

As I mention above,
When I use "Z:\Path To\BrowseRouter\BrowseRouter.exe" %1 the browser will launch
but with the new "Z:\Path To\BrowseRouter\BrowseRouter.exe %1" it will not

I do not know what the specification is for these registry keys, however.

@nref
Copy link
Owner

nref commented Dec 9, 2024

Thanks for the quick feedback. You're right, I put the quote in the wrong spot - I will fix this tomorrow.

@nref
Copy link
Owner

nref commented Dec 10, 2024

Could you please try https://github.com/nref/BrowseRouter/releases/tag/0.13.2? Thanks

@mudnug
Copy link
Author

mudnug commented Dec 10, 2024

I ran the tagged exe several times and it looks like it's putting the expected value in the registry now. Nothing broke.

I will rename #55 so it is more clear what that request is about

@nref
Copy link
Owner

nref commented Dec 11, 2024

Thanks for your help testing the fix!

@nref nref closed this as completed Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants