-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BrowseRouter Registration missing quotes #63
Comments
Thanks for the report. I will fix this in the next few days, or accept a PR. |
Thank you. I'm still trying to work out what the mechanism is that PowerToys uses to trigger searches (which no longer works with BrowseRouter configured as default) The missing quotes was the first thing I came across. I'm not 100% sure on what the quotes should be and I don't know what specification to consult in relation to that. |
When I use |
Fixed in the linked PR and released as https://github.com/nref/BrowseRouter/releases/tag/0.13.1. Would you mind to see if it resolves the issue with PowerToys? |
What's the procedure for me to test this? Would I need to unregister and then register again and then make sure it is set as default in Windows settings? |
Good question. Just double-click the exe and it will update the existing registry keys with the new quoted path. |
Following your steps the app did update the registry. This breaks double clicking on .URL files for me (as well as PowerToys not working). As I mention above, I do not know what the specification is for these registry keys, however. |
Thanks for the quick feedback. You're right, I put the quote in the wrong spot - I will fix this tomorrow. |
Could you please try https://github.com/nref/BrowseRouter/releases/tag/0.13.2? Thanks |
I ran the tagged exe several times and it looks like it's putting the expected value in the registry now. Nothing broke. I will rename #55 so it is more clear what that request is about |
Thanks for your help testing the fix! |
Due to the missing quotation marks it appears that other applications may not be able to launch the app when the path contains spaces.
This is stored as the Data in key Computer\HKEY_CLASSES_ROOT\BrowseRouterURL\shell\open\command
The text was updated successfully, but these errors were encountered: