-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed PlatformMgr().Shutdown() for NRF53 #390
base: master
Are you sure you want to change the base?
Conversation
…down Signed-off-by: Balthazar DELIERS <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @bdlr2,
Thank you for your contribution.
I believe we should not need to call nrf_reset_network_force_off
in the Matter platform, as this should be handled internally by sys_reboot
.
Have you encountered this issue on the nRF5340DK, or only on a custom board? If I had to guess, it's possible you've designed your own board and the nrf5340_cpunet_reset.c
file has not been included in board's CMakeLists.txt
. You can find an example here (note the if-statement): nRF5340DK CMakeLists.txt.
Hello @LuDuda, thanks for the feedback. |
@bdlr2 Have you been able to check the newest SDK if the problem still exists? As i mentioned above, I would like to fix this issue outside of the Matter code. |
@LuDuda no, I didn't check yet. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Remove stale label or comment or this will be closed in 10 days. |
Linked to my case on the DevZone https://devzone.nordicsemi.com/f/nordic-q-a/108101/device-crash-when-doing-a-software-reset
When calling the function
PlatformMgr().Shutdown();
(intentionally, or through a factory reset) a Hard Fault happens because the communication is broken/not in sync anymore between the App and Net cores of the NRF5340. My fix proposes to first reset the network core then reset the application core.